Skip to content

framebuf, text + test #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2018
Merged

framebuf, text + test #14

merged 2 commits into from
Dec 22, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Dec 22, 2018

allow use of adafruit_framebuf if framebuf isnt't available
tested text in the adafruit_framebuf implementation
add a more fully-featured test for framebuf usage

@ladyada ladyada requested review from a team and jerryneedell December 22, 2018 05:38
@eighthree
Copy link

eighthree commented Dec 22, 2018

Hello! I've tested this on a Feather M4 Express with no issues. Example and library seem to work well.

On a trinket m0 I get this error running ssd1306_framebuftest.py as code.py:

Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.
code.py output:
Framebuf capability test - these are slow and minimal but don't requirea special graphics management library, only `adafruit_framebuf`
Pixel test
Lines test
Traceback (most recent call last):
  File "code.py", line 55, in <module>
TypeError: function takes 1 positional arguments but 6 were given

Line 55 looks like:
display.line(corner_from[0], corner_from[1], corner_to[0], corner_to[1], 1)

Earlier today I modified a version of the adafruit_ssd1306 library to test the new adafruit_framebuf library, with only a few line changes:
https://gist.github.com/eighthree/232110a6a35e0d8677eddaea2055560e
This version makes ssd1306_framebuftest.py work without any modifications.

I reckon the error is something else other than what the error message indicates.

@jerryneedell
Copy link
Contributor

jerryneedell commented Dec 22, 2018

The error reported above occurred for me when I had the old "framebuf.py" module on my system. After removing it, it worked. On trinkets, the old framebuf was necessary since the builtin framebuf was not included,

@jerryneedell
Copy link
Contributor

I have tested this on a metro_m4_espress wit ha 128x32 featherwing. For the ssd1306_framebuftest.py I had to change the address to 3c and set the resetpin to None.

@jerryneedell
Copy link
Contributor

jerryneedell commented Dec 22, 2018

worked on my trinket_m0 with oled featherwing.

Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a metro_m4_espress and trinket_m0 with an 128x32 oled featherewing -- both ran the test cases without error. Also ran some "old" ssd1306 code on the metro_m4 -- no issues.
Looks good to me.

Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also tested SPI 132x28 OLED with metro_m4_express -- once I got the pins defined right it was fine ;-)

@jerryneedell jerryneedell requested a review from a team December 22, 2018 15:26
@jerryneedell
Copy link
Contributor

for some reason - my review went in on behalf of circuitpython librarians. I added @adafruit/circuitpythonlibrarians back as a reviewer

@ladyada ladyada merged commit 427c934 into adafruit:master Dec 22, 2018
@ladyada
Copy link
Member Author

ladyada commented Dec 22, 2018

thanx, yah this superscedes the old framebuf, and i didnt keep the same name since there might be some structural changes

tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants