-
Notifications
You must be signed in to change notification settings - Fork 70
framebuf, text + test #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I've tested this on a Feather M4 Express with no issues. Example and library seem to work well. On a trinket m0 I get this error running
Line 55 looks like: Earlier today I modified a version of the adafruit_ssd1306 library to test the new adafruit_framebuf library, with only a few line changes: I reckon the error is something else other than what the error message indicates. |
The error reported above occurred for me when I had the old "framebuf.py" module on my system. After removing it, it worked. On trinkets, the old framebuf was necessary since the builtin framebuf was not included, |
I have tested this on a metro_m4_espress wit ha 128x32 featherwing. For the ssd1306_framebuftest.py I had to change the address to 3c and set the resetpin to None. |
worked on my trinket_m0 with oled featherwing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a metro_m4_espress and trinket_m0 with an 128x32 oled featherewing -- both ran the test cases without error. Also ran some "old" ssd1306 code on the metro_m4 -- no issues.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also tested SPI 132x28 OLED with metro_m4_express -- once I got the pins defined right it was fine ;-)
for some reason - my review went in on behalf of circuitpython librarians. I added @adafruit/circuitpythonlibrarians back as a reviewer |
thanx, yah this superscedes the old framebuf, and i didnt keep the same name since there might be some structural changes |
Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.5.0 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#14 from ladyada/master > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#13 from sommersoft/readme_fix_travis
allow use of adafruit_framebuf if framebuf isnt't available
tested text in the adafruit_framebuf implementation
add a more fully-featured test for framebuf usage