Skip to content

optional column offset #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

mikeysklar
Copy link
Contributor

column offset had been hard coded to 4.

An updated ADA# 2675 128x32 2.3" Monochrome OLED needs an offset of col=0 to work.

Col=4 will remain default, but this override is being added for this one model which has changed behavior.

forum issue

Test on:

Pi4, Bookworm Lite, 64-bit with ADA# 2675

new constructor example:

oled = adafruit_ssd1305.SSD1305_I2C(WIDTH, HEIGHT, i2c, addr=0x3c, reset=oled_reset, col=0)

column offset had been hard coded to 4.

An updated ADA# 2675 128x32 2.3" Monochrome OLED needs an offset of col=0 to work.

Col=4 will remain default, but this override is for this one model which has changed.
@mikeysklar
Copy link
Contributor Author

Adafruit OLED 2675 changed from blue to white and now requires col=0 offset be passed in to work. The driver had been hardcoded to col=4. The existing models and other SSD1305 libraries don't necessarily need the column offset option.

This PR has been tested by myself and the original user who brought it up forum user jmiller88.

@ladyada

@ladyada
Copy link
Member

ladyada commented Mar 27, 2025

nice work!

@ladyada ladyada merged commit a72bc77 into adafruit:main Mar 27, 2025
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 3, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_INA228 to 1.0.1 from 1.0.0:
  > Update adafruit_ina228.py

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1305 to 1.4.0 from 1.3.21:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1305#16 from mikeysklar/ssd1305-white-module-col-offset

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV320 to 1.0.0 from 51c14aa:
  < Update README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 2.3.0 from 2.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#70 from tannewt/cmap03

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.2.4 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#219 from FoamyGuy/use_ruff

Updating https://github.com/adafruit/Adafruit_CircuitPython_JSON_Stream to 0.9.0 from 0.8.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_JSON_Stream#9 from Neradoc/iterator-on-objects
  > Merge pull request adafruit/Adafruit_CircuitPython_JSON_Stream#8 from Neradoc/fix-string-in-string

Updating https://github.com/adafruit/Adafruit_CircuitPython_USB_Host_Descriptors to 0.2.1 from 0.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Descriptors#4 from FoamyGuy/two_mice_example
  > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Descriptors#3 from FoamyGuy/find_mouse_helper

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_TLV320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants