Skip to content

fix OSError response for CP 3.0 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2017
Merged

fix OSError response for CP 3.0 #6

merged 1 commit into from
Dec 31, 2017

Conversation

jerryneedell
Copy link
Contributor

After discuiion with @deshipu and @dhalbert implemented changes to init and _data to accept all OSErrors during reset. Apparently changed from CP 2.x to 3.x resulted in different responses. This approach is consistent with other drivers such as bno055

@jerryneedell jerryneedell requested a review from deshipu December 28, 2017 17:57
@jerryneedell jerryneedell mentioned this pull request Dec 28, 2017
Copy link
Contributor

@deshipu deshipu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@jerryneedell
Copy link
Contributor Author

Is this waiting for additional review?

@dhalbert
Copy link
Contributor

If it's tested on 2.2 and 3.0 that's fine. I didn't have one of these to test. So I'll merge and make a release?

@jerryneedell
Copy link
Contributor Author

I can’t recall if I tested 2.2 I’ll update when I have.

@jerryneedell
Copy link
Contributor Author

Tested on 2.2 rc2 with 20171227 lib Bundle. No problems.
I can do the merge and release (I think) if you want me to. I was just unsure how the process worked at this stage. If you want me to do it, just let me know if there are any special things I need to know before I start clicking buttons ;-)

@dhalbert
Copy link
Contributor

Go ahead if you have the privs. Just click Merge pull request. Then go to the Releases page and click "Draft a new release". Pick a version number that makes sense based on the changes, add a few pertinent comments and publish it. Travis will take care of the rest after a few minutes.

@jerryneedell jerryneedell merged commit 785f8ba into adafruit:master Dec 31, 2017
@jerryneedell jerryneedell deleted the jerryn_fix3x branch December 31, 2017 18:09
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants