including_suggestions

Author: jposada202020

adafruit_si5351.py

@@ -172,8 +172,8 @@ def configure_integer(self, multiplier):
             """Configure the PLL with a simple integer multiplier for the most
             accurate (but more limited) PLL frequency generation.
             """
-            if multiplier > 91 or multiplier < 14:
-                raise Exception("multiplier must be between 14 and 91")
+            if multiplier >= 91 or multiplier <= 14:
+                raise Exception("Multiplier must be in range 14 to 91.")
             multiplier = int(multiplier)
             # Compute register values and configure them.
             p1 = 128 * multiplier - 512
@@ -193,15 +193,15 @@ def configure_fractional(self, multiplier, numerator, denominator):
             multiplier and numerator/denominator.  This is less accurate and
             susceptible to jitter but allows a larger range of PLL frequencies.
             """
-            if multiplier > 91 or multiplier < 14:
-                raise Exception("multiplier must be between 14 and 91")
+            if multiplier >= 91 or multiplier <= 14:
+                raise Exception("Multiplier must be in range 14 to 91.")
             if denominator > 0xFFFFF or denominator <= 0:  # Prevent divide by zero.
                 raise Exception(
-                    "denominator must be greater than 0 and lower than 0xFFFFF"
+                    "Denominator must be in range 0 to 0xFFFFF."
                 )
-            if numerator > 0xFFFFF or numerator < 0:
+            if numerator >= 0xFFFFF or numerator < 0:
                 raise Exception(
-                    "numerator must be greater than 0 and lower than 0xFFFFF"
+                    "Numerator must be in range 0 to 0xFFFFF."
                 )
             multiplier = int(multiplier)
             numerator = int(numerator)
@@ -288,7 +288,7 @@ def r_divider(self):
         @r_divider.setter
         def r_divider(self, divider):
             if divider > 7 or divider < 0:
-                raise Exception("divider must be between 0 and 7")
+                raise Exception("Divider must in range 0 to 7.")
             reg_value = self._si5351._read_u8(self._r)
             reg_value &= 0x0F
             divider &= 0x07
@@ -316,11 +316,11 @@ def configure_integer(self, pll, divider):
             frequency but supports less of a range of values.
             """
             if divider >= 2049 or divider <= 3:
-                raise Exception("divider must be between 3 and 2049")
+                raise Exception("Divider must be in range 3 to 2049.")
             divider = int(divider)
             # Make sure the PLL is configured (has a frequency set).
             if pll.frequency is None:
-                raise Exception("PLL must be configured")
+                raise Exception("PLL must be configured.")
             # Compute MSx register values.
             p1 = 128 * divider - 512
             p2 = 0
@@ -343,21 +343,21 @@ def configure_fractional(self, pll, divider, numerator, denominator):
             accurate but has a wider range of output frequencies.
             """
             if divider >= 2049 or divider <= 3:
-                raise Exception("divider must be between 3 and 2049")
+                raise Exception("Divider must be in range 3 to 2049.")
             if denominator > 0xFFFFF or denominator <= 0:  # Prevent divide by zero.
                 raise Exception(
-                    "denominator must be greater than 0 and lower than 0xFFFFF"
+                    "Denominator must be in range 0 to 0xFFFFF."
                 )
-            if numerator > 0xFFFFF or numerator < 0:
+            if numerator >= 0xFFFFF or numerator < 0:
                 raise Exception(
-                    "numerator must be greater than 0 and lower than 0xFFFFF"
+                    "Numerator must be in range 0 to 0xFFFFF."
                 )
             divider = int(divider)
             numerator = int(numerator)
             denominator = int(denominator)
             # Make sure the PLL is configured (has a frequency set).
             if pll.frequency is None:
-                raise Exception("PLL must be configured")
+                raise Exception("PLL must be configured.")
             # Compute MSx register values.
             p1 = int(128 * divider + math.floor(128 * (numerator / denominator)) - 512)
             p2 = int(