Skip to content

Remove stop kwarg and use write_then_readinto. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 21, 2019

See adafruit/circuitpython#2082 for details.

@tannewt tannewt requested a review from caternuson August 21, 2019 05:11
@caternuson
Copy link
Contributor

I will test.

@caternuson
Copy link
Contributor

Hmmm. So in testing this I think I've found another potential bug. A station with less than 8 characters does not get updated for some reason. This is happening with the current master and with this PR code. There's probably some basic issue with how the I2C comms are working which will take some datasheet reading and further testing.

This PR code works as well as current master. So two options:

  1. merge this with TODOs left in, and open a new issue for the above
  2. don't merge this, open a new issue for above that also includes updating for kwarg change (so two birds with one PR)

I'm leaning toward 1. Thoughts?

@ladyada
Copy link
Member

ladyada commented Aug 28, 2019

not worth spending time on, this chip is about to be discontinued anyhow. plz go with #1

@caternuson
Copy link
Contributor

cool, thanks. will do that...

@caternuson
Copy link
Contributor

tested

import board, digitalio, adafruit_si4713
si_reset = digitalio.DigitalInOut(board.D10)
si4713 = adafruit_si4713.SI4713(board.I2C(), reset=si_reset, timeout_s=0.5)
si4713.tx_frequency_khz = 87500
si4713.tx_power = 115
si4713.configure_rds(0xADAF, station=b'IAMPR8:)', rds_buffer=b'boots and pants')

image

@caternuson caternuson merged commit 85f2e10 into adafruit:master Aug 28, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 28, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#17 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#16 from peterhinch/temperature_fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.2.0 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#18 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.4.0 from 2.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#15 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.3.0 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#12 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#8 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#5 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_GC_IOT_Core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants