Some RDS fixes #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jul 12, 2019
|
can merge after travis happy |
|
epic, thanks! |
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 12, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.5.0 from 1.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#29 from martymcguire/mm-chunk-socket-sends Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#7 from caternuson/iss2_rds Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#8 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.0 from 0.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#3 from kattni/business-card-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for #2. The
_BUFFERgets overwritten with response so must be rebuilt each time in loop. This fixesstationand same fix was applied tords_buffer. However, I could never get the contents ofrds_bufferto show up anywhere. Same thing testing with Arduino version. The documentation on that is...poor. The reference for theTX_RDS_BUFFcommand does not match what is shown in the programming example in AN332 Si47XX Programming Guide.