adafruit_si4713: prefer 'struct', falling back to 'ustruct' #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
force-pushed
the
import-struct
branch
2 times, most recently
from
f170e93 to
575c90c
Compare
tannewt
approved these changes
May 3, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 8, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#7 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_Pixie to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Pixie#5 from kattni/pypi > Merge pull request adafruit/Adafruit_CircuitPython_Pixie#4 from kattni/documentation-setup > Merge pull request adafruit/Adafruit_CircuitPython_Pixie#3 from kattni/documentation-setup Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 1.2.0 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#9 from kattni/pypi Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#7 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.1.0 from 3.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#22 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#18 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#17 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.2.1 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_SD#10 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#8 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#7 from adafruit/tannewt-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#6 from brentru/sensor-prop > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#5 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#4 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_SH to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SH#7 from kattni/driver-rename > Merge pull request adafruit/Adafruit_CircuitPython_SH#6 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#3 from jepler/import-struct Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#2 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.1.0 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#9 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#8 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#7 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.4.0 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#11 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#6 from kattni/pypi Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.1.0 from 3.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#6 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#5 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermal_Printer to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.3 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#18 from kattni/minor-fixes > updated CoC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at adafruit/circuitpython#782 it will be necessary in CircuitPython 3.0 to import 'struct' instead of 'ustruct'. Use the import syntax suggested in that issue, tidying up references to ustruct; a sphinx documentation workaround becomes unneeded by doing this.
I do not actually have the si4713 hardware, so I was unable to perform any testing.