Skip to content

add delays to match arduino change #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023
Merged

add delays to match arduino change #21

merged 1 commit into from
Jul 3, 2023

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Jun 24, 2023

@ladyada ladyada requested a review from tekktrik June 24, 2023 16:46
@ladyada
Copy link
Member Author

ladyada commented Jun 24, 2023

thanks @Cardenas-Synth please take a look - does this seem right to you?

Copy link

@Cardenas-Synth Cardenas-Synth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were the changes I made! I feel that approving these issues will fix my specific issues, and possibly others considering most of the issues seem recent.

Thank!

@caternuson
Copy link
Contributor

Just received new breakout. Can recreate issue with existing library:

Adafruit CircuitPython 7.3.3 on 2022-08-29; Adafruit QT Py RP2040 with rp2040
>>> import board
>>> import adafruit_sgp40
>>> i2c = board.STEMMA_I2C()
>>> sgp = adafruit_sgp40.SGP40(i2c)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/lib/adafruit_sgp40/__init__.py", line 123, in __init__
  File "/lib/adafruit_sgp40/__init__.py", line 146, in initialize
  File "/lib/adafruit_sgp40/__init__.py", line 293, in _read_word_from_command
OSError: [Errno 19] No such device
>>> 

and confirm the increase delay fixes:

Adafruit CircuitPython 7.3.3 on 2022-08-29; Adafruit QT Py RP2040 with rp2040
>>> import board
>>> import adafruit_sgp40
>>> i2c = board.STEMMA_I2C()
>>> sgp = adafruit_sgp40.SGP40(i2c)
>>>  

@caternuson caternuson merged commit 1f9dd7f into main Jul 3, 2023
@dhalbert dhalbert deleted the fixdelay branch July 17, 2023 04:06
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants