Skip to content

make eco2 + tvoc properties to match sensor standard #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ladyada opened this issue Oct 25, 2017 · 4 comments
Closed

make eco2 + tvoc properties to match sensor standard #1

ladyada opened this issue Oct 25, 2017 · 4 comments
Labels
good first issue hacktoberfest

Comments

@ladyada
Copy link
Member

ladyada commented Oct 25, 2017

ed1db09#commitcomment-25187627
@sommersoft
Copy link
Collaborator

sommersoft commented Oct 2, 2018 •
edited
Loading

To clarify, change all property instances of tvoc to TVOC, and eco2 to eCO2.

Outlined in the design guide here.

Like so:

# old
@property
    def tvoc(self):
# new
@property
    def TVOC(self):

@ladyada
Copy link
Member Author

ladyada commented Oct 2, 2018

yep thats it - super easy :D but have to update examples, readme too!

@kattni kattni mentioned this issue Oct 6, 2018
Open
@process1183
Copy link
Contributor

I'd be happy to work on this one!

@ladyada
Copy link
Member Author

ladyada commented Oct 11, 2018

@process1183 go for it!

@process1183 process1183 mentioned this issue Oct 12, 2018
Merged
sommersoft added a commit that referenced this issue Oct 12, 2018
@sommersoft
Merge pull request #10 from process1183/standardize
9ea6a98 
Update eCO2 and TVOC properties to match sensor standard (closes #1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tannewt @ladyada @sommersoft @process1183