When sending data get the bytes length not the string length #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always converts
data
from string to bytes before getting the length.Otherwise data that contains UTF-8 characters gets truncated if the server follows the content length.
data
is still converted tobytes
if not a string. (Is it necessary ?)This was reported in the support forums by testing with pushover.net (using the desktop in-browser interface to receive the messages).
ñ
and°
are encoded with 2 bytes.This is the result in the browser, before the fix is the bottom one. 2 characters are missing.
Note that what gets cut depends on the order in which the parameters end up, dicts are not ordered in CP so the loop goes through them in no particular order. In this example it's the message that ends up last.
I only tested that, and some of the examples from this repository.