Optimize UnaryStruct memory use for when its unused #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a bytearray buffer costs 32 bytes for every UnaryStruct even when its not used. This makes code size a bit larger but its shared amongst all instances.
|
Can someone review this please? |
|
hiya i dont see anything conceptually amiss here, want me to test with some i2c hardware that uses this library? |
|
@ladyada I've tested it on my end so its up to you if you want to test before approving. |
|
tested with AMG8833 - works good! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 7, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.1.0 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#10 from tannewt/struct_array Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Register#9 from tannewt/struct_opt > Merge pull request adafruit/Adafruit_CircuitPython_Register#10 from tannewt/struct_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
__init__create a bytearray buffer costs 32 bytes for every UnaryStructeven when its not used. This makes code size a bit larger but its
shared amongst all instances.