Skip to content

Don't use offset kwd in struct.unpack_from() #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

dhalbert
Copy link
Contributor

Workaround for adafruit/circuitpython#984 not being fixed yet. Leave this in since it will work for builds before that fix happens as well.

Also would have fixed adafruit/Adafruit_CircuitPython_Motor#11, which accidentally no longer throws an error due to adafruit/Adafruit_CircuitPython_Motor#10.

@dhalbert dhalbert requested a review from tannewt July 31, 2018 22:59
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 1e4311b into adafruit:master Aug 2, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 4, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 2.3.2 from 2.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#13 from kattni/pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.1.1 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Crickit#9 from kattni/pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.2.0 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#13 from kattni/pypi-fixes
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#11 from adafruit/pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.3.0 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#26 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 0.9.0 from 0.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#6 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#5 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 1.3.0 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#7 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#6 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#5 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.1.0 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#6 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.3.1 from 4.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#38 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#37 from kattni/pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.3.0 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#30 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#29 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.2.1 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#15 from kattni/pypi-fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.2.0 from 3.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#6 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#5 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#16 from kattni/pypi-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#15 from kattni/pypi-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#8 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#6 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#16 from adafruit/badge-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#15 from dhalbert/unpack_from-offset
  > updated CoC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor: print statements in Example code fail on motor4.throttle
2 participants