Fix timing of dotted notes #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotting a note lengthens it by 1/2. In the code, the `duration` parameter is actually a divisor of the length of the note (e.g. 1 is a whole note but 4 is a quarter note (1/4 the length)), so dotting should divide the `duration` by 1.5 instead of multiplying.
FoamyGuy
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Thanks for the fix @duckythescientist.
The change looks good to me. I wasn't familiar with the spec, but confirmed the dotting syntax here: https://en.wikipedia.org/wiki/Ring_Tone_Text_Transfer_Language
Tested the fix successfully with:
adafruit_rtttl.play(board.SPEAKER,
"TestSong: d=4,o=5,b=148: 1c, 1e, 1f., 1c")
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 13, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_HCSR04 to 0.4.14 from 0.4.13: > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#29 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7565 to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_ST7565#5 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#17 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.14 from 1.5.13: > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#33 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.11 from 2.22.10: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#174 from snkYmkrct/main Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.13 from 1.2.12: > Merge pull request adafruit/Adafruit_CircuitPython_JWT#16 from tekktrik/dev/issue-12 Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.19 from 2.4.18: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#33 from duckythescientist/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotting a note lengthens it by 1/2. In the code, the
durationparameter isactually a divisor of the length of the note (e.g. 1 is a whole note but 4
is a quarter note (1/4 the length)), so dotting should divide the
durationby 1.5 instead of multiplying.