Code fails duplicate-code check, consider refactor

[evaherrada]

https://github.com/adafruit/Adafruit_CircuitPython_RSA/runs/6993443865?check_suite_focus=true#step:11:33

[kattni]

Assigning Tekktrik as well to look into this. We'll work together to decide what the best solution is.

[tekktrik]

I'm not sure what compatibility it is preserving, but I would say we should remove one of the duplicates if possible if it won't break anything. Or, if it will, we explore changing it there too 😅

[tekktrik]

This library is a candidate for refactoring based on pylint warning of duplicate code. The solution for this library would be to refactor the code to not have duplicated portions of code. In most cases, this might mean making base classes/functions so code can be recycled, but in some cases it may mean removing duplicate functionality (e.g., for compatibility).

To determine the duplicate code section, allow pylint to warn against duplicated code by removing ,duplicate-code from .pre-commit-config.yaml and then running pre-commit:

Adafruit_CircuitPython_RSA/.pre-commit-config.yaml

Line 27 in 118b283

- --disable=consider-using-f-string,duplicate-code

Then, refactor the duplicated code sections until it passes pre-commit. The modified .pre-commit-config.yaml file and refactored code can then be submitted as a PR.