Update README.rst #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the example code: 1. `D2` was imported twice as a typo. `D3` was meant to be imported in place of the mistaken second import of `D2`. 2. `time.sleep(2)` on the last line was mistakenly tabbed out of the scope of the infinite loop. The code would thus be unreachable making the command of filling the screen with blue too fast.
deshipu
approved these changes
Jan 28, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 28, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.0.2 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#14 from jakebird451/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example code:
D2was imported twice as a typo.D3was meant to be imported in place of the mistaken second import ofD2.time.sleep(2)on the last line was mistakenly tabbed out of the scope of the infinite loop. The code would thus be unreachable making the command of filling the screen with blue too fast.