Implement "reliable Datagram mode" #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got a pair of RFM95 Featherwings ordered from Digikey on the way. I can test this PR with them once they arrive if it's helpful, hopefully within the next few days. |
Great! I’ll wait for your testing before merging. No rush. |
FoamyGuy
approved these changes
May 1, 2020
There was a problem hiding this comment.
Tested successfully with 2x RFM9x Featherwing using the node1 / node2 example scripts and their ack variants.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 2, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#17 from caternuson/iss3 Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.0.0 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#42 from jerryneedell/jerryn_ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented compatibility with the RadioHead library "Reliable DataGram" mode. see #34 .
Received packets ar "ACKed" and Transmitted packets wait for ACK response.
It has been difficult to make this work reliably. Packets will still be missed occasionally but now they will be reported. There are attributes that can be "tweaked" to help
rfm9x.ack_delay -- set a delay before the ACK packet is sent - this is necessary when the receive unit an MCU communication to a Raspberry Pi . The MCU can send it's ACK packet before the Raspberry Pi has resumed "listening". The default setting is "None" but setting it to .1 seconds may be necessary. The Arduino RadioHead library does not allow for this "ack_delay" and it it may be difficult to get this to work, especially with a Raspberry Pi.
rfm9x.retries -- set the number of ack retries
All of the existing examples will still execute without change.
There are "breaking changes" for anyone that had been setting the RadioHead headers directly.
There are now attributes for setting the header parameters and the rx_filter parameter for the receive function has been removed.
There are examples for using this mode in rfm9x_node1_ack.py and rfm9x_node2_ack.py
other new examples
rfm9x_header.py -- receive packets and display the header and packet contents
rfm9x_node1.py -- uses adresses without ACK
rfm9x_node2.py -- companion to rfm9x_node1.py
rfm9x_rpi_simpletest.py - no LED and set pins for RaspBerry Pi
rfm9x_node1_bonnet.py -- similar to rfm9x_node1.py but for use with RPi and bonnet -- uses buttons to sent packets
the changes are very similar to adafruit/Adafruit_CircuitPython_RFM69#24 and hopefully many lessons learned were applied