Add Missing Type Annotations #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

FoamyGuy merged 2 commits into adafruit:main from tcfranks:main

Oct 10, 2022

Contributor

tcfranks commented Sep 28, 2022

resolves #37
submitted for review / comment


          Add Missing Type Annotations

e547653

tekktrik requested a review from a team

September 29, 2022 15:04

gamblor21 reviewed

View reviewed changes

adafruit_rfm69.py Outdated Show resolved Hide resolved

requirements.txt Show resolved Hide resolved


          corrected return types and added 'Callable' as argument to check_timeout

be5a74a

Contributor Author

tcfranks commented Oct 9, 2022

resubmitted for review

FoamyGuy requested changes

View reviewed changes

Contributor

FoamyGuy left a comment

One tweak to encryption_key property functions I think.

Beyond that this is looking good to me.

adafruit_rfm69.py Show resolved Hide resolved

FoamyGuy approved these changes

View reviewed changes

Contributor

FoamyGuy left a comment

Looks good to me. Thanks for working on another of these @tcfranks

FoamyGuy merged commit 96b4a05 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@eaa233b)

1f32bbf

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.7 from 5.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#108 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 2.1.13 from 2.1.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#42 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.9 from 1.19.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#76 from The-Debarghya/bug-75-zerodivisionerror

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.2.0 from 4.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#40 from tekktrik/dev/allow-root-logger

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.5.2 from 5.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#122 from calcut/fetch_all_messages_in_loop

Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.12 from 2.5.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#37 from tekktrik/dev/fix-install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet