Added content-length header check #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Oct 8, 2020
|
What is the core problem? Missing content-length is actually valid. We have an open issues on Requests to support it because Hue lights' API server omits it: adafruit/Adafruit_CircuitPython_Requests#38 |
|
@tannewt, the problem was that it was blindly trying to read "content-type" and if that was missing it would just completely error out. This just gives it a nicer message, but ideally should be written to deal with the content type missing, which is another issue altogether. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 13, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.5.0 from 3.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#88 from makermelissa/http-errors > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#87 from makermelissa/content-headers > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#80 from virgilvox/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.