change from using adafruit_sdcard to sdcardio

[cjsieh]

Change from adafruit_sdcard to sdcardio .

[cjsieh]

This is for adafruit/circuitpython#3309. Note that adafruit_sdcard has issues and fails on the PyPortal and PyGamer.

[cjsieh]

pylint errors because of upgrade of pylinit to 2.6.0 .

[ladyada]

@makermelissa hey hey this needs the new exceptionizalation

[makermelissa]

Ok, should be quick. I'll submit a PR.

[makermelissa]

The pylint updates are now merged in. @cjsieh, please pull in latest changes from repo and push again.

[FoamyGuy]

I think the previous actions issue was a temporary problem. Something in the installing dependencies section failed to download the proper file. I re-ran the jobs and it did get past that issue.

After that it did need one minor change in the docs config file to include sdcardio in the list of mocked imports.

[FoamyGuy]

I tested this successfully on
Adafruit CircuitPython 6.0.0-alpha.3 on 2020-08-28; Adafruit PyPortal with samd51j20

Ordinarily I would think we'd want some sort of backwards compatibility since sdcardio is not in a stable release yet. But it wasn't working previous as noted by the issue on the core repo noted above. Maybe something could be done in adafruit_sdcard to fix it and then backward compatibility could be provided here.

This looks good to me. Thanks for this fix @cjsieh!

I am curious if anyone else has thoughts or ideas about the backward compatibility aspect of it. If we merge this then the library will crash on 5.3.1. It would need to be used with a newer alpha release at this time.

[tannewt]

Until 6.0.0 is stable I think we want this to be backwards compatible because it does work for many uses on 5.3.1. I've commented what needs to be changed for backwards compatibility I think.

[tannewt]

Thank you!

[tannewt]

@FoamyGuy Mind retesting this? Thanks!

[FoamyGuy]

I retested this. Still working successfully on 6.0.0-alpha.3 and no longer crashes on import on 5.3.1.