Skip to content

some more comments! #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 23, 2019
Merged

some more comments! #2

merged 6 commits into from
Feb 23, 2019

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Feb 23, 2019

just about ready for bundlin'

@ladyada ladyada requested a review from kattni February 23, 2019 20:48
kattni
kattni approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for completing the comments. Ready for merge once Travis passes.

@kattni kattni merged commit 970569a into adafruit:master Feb 23, 2019
brentru pushed a commit that referenced this pull request Jun 6, 2019
@jasonlshelton
Merge pull request #2 from jasonlshelton/Add_Push_IO
eebcd41 
Add push io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @kattni