Assign requests if we have already connected #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Apr 7, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 8, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.0 from 2.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_BME280#45 from gbaman/patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.0.3 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#52 from kattni/import-fix > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.0.3 from 6.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#109 from kattni/import-fix > "Increase duplicate code check threshold " > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#105 from FoamyGuy/pylint_to_precommit Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.1.6 from 5.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#108 from makermelissa/master > "Increase duplicate code check threshold "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adafruit/Adafruit_CircuitPython_PortalBase#24. The issue is that requests was only assigned once we called connect, but if we were already connected, requests was never assigned.