Refactor to improve readability and reduce code duplication #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method can be used to reduce code duplication in several areas of the library, and introduces common shared defaults such as black for the font color.
nnja
force-pushed
the
refactor_to_reduce_code_dupe
branch
from
4941869 to
de254d0
Compare
|
@makermelissa please review :) |
|
Tested on EdgeBadge, working well. Looks good to me. |
makermelissa
approved these changes
Feb 14, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 15, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#5 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 5.1.1 from 5.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#68 from tannewt/adafruit_ble_package > Merge pull request adafruit/Adafruit_CircuitPython_BLE#67 from tannewt/service_data > Merge pull request adafruit/Adafruit_CircuitPython_BLE#66 from tannewt/multivalue_mfg Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.3.2 from 2.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#34 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.0.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#37 from geekguy-wy/removing_deinits Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#19 from nnja/refactor_to_reduce_code_dupe > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#18 from nnja/add_blinka_bmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if these types of contributions are welcome, but I introduced a new
_create_label_groupmethod to thePyBadgerclass to help improve code readability and reduce code duplication.Tested on a PyBadge LC.