margin_size seems to be int like in Vertical and Horizontal #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is confusing. Not sure when margin_size ever was a bool, but it looks like an int to me.
FoamyGuy
approved these changes
Apr 21, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 25, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.12.0 from 2.11.1: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#125 from jposada202020/PacMan_animation > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#124 from jposada202020/blink-with-user-color-selected-background Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.2.5 from 3.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#100 from Neradoc/fix-feather-pins > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#99 from Neradoc/fix-matrix-docs Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 8.0.1 from 8.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#249 from Neradoc/fix-missing-exception-argument Updating https://github.com/adafruit/Adafruit_CircuitPython_Pathlib to 1.0.1 from 1.0.0: > use characters we can show with terminalio in example readme code > use characters we can show with terminalio in example Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.3.17 from 2.3.16: > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#41 from dglaude/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_USB_Host_Descriptors to 0.3.0 from 0.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Descriptors#7 from FoamyGuy/find_boot_keyboard Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Pathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation is confusing.
Not sure when margin_size ever was a bool, but it looks like an int to me.
Took the description found in:
https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar/blob/283822cd1a1c43031a460405d1f46be3d04ee28c/adafruit_progressbar/horizontalprogressbar.py#L101C1-L104C27
and in:
https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar/blob/283822cd1a1c43031a460405d1f46be3d04ee28c/adafruit_progressbar/verticalprogressbar.py#L102C1-L106C1