Skip to content

Fix bug with decrementing progress bar, add set-able progress bar color fill #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2020
Merged

Fix bug with decrementing progress bar, add set-able progress bar color fill #2

merged 2 commits into from
Jan 9, 2020

Conversation

brentru
Copy link
Member

@brentru brentru commented Jan 8, 2020

  • Progress bar does not leave graphical artifacts at progress_val while decrementing, writes to width-margin instead

  • Adding a fill setter/getter method to allow someone to change the progress bar's color

    • Useful for applications where someone would want to display a "warning" color

Tested on Adafruit CircuitPython 5.0.0-beta.2 on 2019-12-20; Adafruit PyPortal with samd51j20

@brentru brentru added bug Something isn't working enhancement New feature or request labels Jan 8, 2020
@brentru brentru requested a review from a team January 8, 2020 22:41
@ladyada ladyada merged commit f089ce1 into adafruit:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @ladyada