Updated to work with settings.toml and secrets.py #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only caveat with this change is since this library is normally frozen into CircuitPython (for the MatrixPortal M4 and other M4-based boards), we may need another release before updating guides. |
FoamyGuy
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Looks good to me. Thank you @makermelissa!
I tested successfully on a PyPortal Titano 8.2.1 with the example from this repo using:
- settings.toml
- secrets.py
- neither secrets.py nor settings.toml
All cases are working as expected.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 2, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.15.1 from 1.14.9: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#94 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#93 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with various combinations of settings in settings.toml and secrets.py.