-
Notifications
You must be signed in to change notification settings - Fork 19
Secrets cleanup #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets cleanup #105
Conversation
@dhalbert I will make the |
@justmobilize There are other libraries that use PortalBase: FunHouse, MagTag, ESP32S2TFT, Qualia, MatrixPortal (using the short names). I grep'd for |
@dhalbert doing a search, PyPortal was the only one that used secrets_data: https://github.com/search?q=org%3Aadafruit%20secrets_data&type=code |
@justmobilize 😄 ok, great! |
Ahhh, didn't catch one. It's also used in the |
I often search in a local clone of https://github.com/adafruit/Adafruit_CircuitPython_Bundle instead of using the GitHub search. |
I did that originally. The blinka one isn't in there (since it's for CPythpn) and then when I sent you the GitHub search, I just saw PyPortal. |
Issue opened adafruit/Adafruit_Blinka_PyPortal#23 |
@dhalbert this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I cleaned up the error messages a bit.
Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 2.0.0 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_Hue#24 from justmobilize/remove-secrets-and-more Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 3.0.0 from 2.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#25 from justmobilize/remove-secrets-and-more Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 3.0.0 from 2.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#105 from justmobilize/secrets-cleanup
Minor updates to remove secrets usage and update keys:
secrets_data
secrets.py
comments tosettings.toml
AIO_*
toADAFRUIT_AIO_*
adafruit_portalbase.network.NetworkBase._get_setting
to handle newerADAFRUIT_AIO_*
key names and show a warning when using secrets (tests added to make sure it's working as expected)Tested on a PyPortal running 9.2.4