Skip to content

Change to allow passing in secrets in blinka pyportal #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

makermelissa
Copy link
Collaborator

Tested with current iteration of refactored PyPortal and it works without modification, which is the only one that would have been affected.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this raise needs to get removed, in order for the code to be able to run in environments without a secrets.py file.

I tried to test with the adafruit_pyportal libarary, but found that it will need some modifications in order to support the lack of secrets.py file if we want to use it like this.

I ended up testing these changes successfully (after removing the raise) using adafruit_blinka_pyportal library from the open refactoring PR

The only other minor potential change I noticed is perhaps we want to make some of the docstring wordings a little bit more generic because a few of them refer specifically to a secrets.py file. But this does not prevent the library from working.

@jfurcean
Copy link

I think the debugging print statement on line 305 needs to be updated as well.

print("Connecting to AP", secrets["ssid"])

should be

print("Connecting to AP", self._secrets["ssid"])

@makermelissa
Copy link
Collaborator Author

Sounds like good changes. I just pushed those items.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tested successfully after the latest commit. Looks good to me.

Thank you @makermelissa
Nice catch @jfurcean thank you for looking it over as well!

@makermelissa makermelissa merged commit 490c83a into adafruit:main Jan 16, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants