Skip to content

Initial working version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Initial working version #1

merged 2 commits into from
Dec 7, 2020

Conversation

makermelissa
Copy link
Collaborator

This is an initial working version. Most function were taken from the MagTag library in order to get the latest versions of things. It is not meant to be used by itself, so there are no examples.

@makermelissa makermelissa requested a review from a team December 4, 2020 23:47
@makermelissa
Copy link
Collaborator Author

makermelissa commented Dec 4, 2020

To test, you can use adafruit/Adafruit_CircuitPython_MagTag#35 which should run any existing MagTag scripts without changes. I tested on MagTag the examples already.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this successfully with the linked MagTag PR branch and the progress display scripts that I've been working on.

@makermelissa makermelissa merged commit 25a8b5c into adafruit:main Dec 7, 2020
@makermelissa
Copy link
Collaborator Author

Thanks for testing


def qrcode(
self, qr_data, *, qr_size=1, x=0, y=0, qr_color=0x000000
): # pylint: disable=invalid-name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see this split out into it's own widget like label. That way we can use it outside of portal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Please elaborate. I think I know what you mean, but want to be sure. Do you mean as part of an existing library or a maybe new library?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking a new library or even part of the QRCode library. It'd be an object that represents the QRCode on screen. The constructor would take the parameters here and the object would inherit from Group so you could use and manipulate it like a normal group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants