Skip to content

Not the same signature as the builtin version #7

Closed
@Neradoc

Description

@Neradoc
  • n versus size
  • keyword only arguments after that in the builtin version
  • different type hints and default values for the header and trailer (not a big deal)
class adafruit_pixelbuf.PixelBuf(n: int, byteorder: str = 'BGR', brightness: float = 1.0,
auto_write: bool = False, header: Optional[bytes] = None, trailer: Optional[bytes] = None):
class adafruit_pixelbuf.PixelBuf(size: int, *, byteorder: str = 'BGR', brightness: float = 0,
auto_write: bool = False, header: circuitpython_typing.ReadableBuffer = b'', trailer: circuitpython_typing.ReadableBuffer = b''):

I think all the real-world uses work with both, giving the size as positional and the rest as keywords.
So I wonder if something should be done about that ?
(In addition the default brightness is wrong in the builtin docs but that's not an incompatibility).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions