Skip to content

Add typing, update documentation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 28, 2021
Merged

Add typing, update documentation #31

merged 6 commits into from
Dec 28, 2021

Conversation

tekktrik
Copy link
Member

Addresses Issue #26 by adding type hints, and also corrects some docstrings to better reflect typing and parameter, including Sphinx markup

@ladyada ladyada requested a review from FoamyGuy December 28, 2021 02:01
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @tekktrik

tested successfully with pyportal

@FoamyGuy FoamyGuy merged commit ce76606 into adafruit:main Dec 28, 2021
@FoamyGuy FoamyGuy mentioned this pull request Dec 28, 2021
12 tasks
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 29, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.4 from 0.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#12 from Neradoc/version-and-repo

Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.4.7 from 1.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#26 from adafruit/pb-rgbw
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.3.4 from 3.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#60 from FoamyGuy/pwmio_types_str

Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.1 from 2.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#31 from tekktrik/doc/add-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#29 from FoamyGuy/background_fix
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#30 from FoamyGuy/text_background_color

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.10.4 from 1.10.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#91 from Neradoc/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants