Skip to content

Add a link to the PIO tutorial #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2022
Merged

Add a link to the PIO tutorial #33

merged 2 commits into from
Jan 8, 2022

Conversation

dannystaple
Copy link
Contributor

No description provided.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Jan 8, 2022

@dannystaple thanks for adding this. The CI checks failed due to no extra newline at the end of index.rst file. Can you add that and push a commit with it?

If you are interested you can set up pre-commit in your local environment to find/fix some of the possible CI errors. There is a guide that covers the process here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

@dannystaple
Copy link
Contributor Author

@FoamyGuy thanks for that - I've got it installed - a good way to run pre-flight CI. I was running unittests and black on python code from my terminal - but hadn't come across that one.

FoamyGuy
FoamyGuy approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @dannystaple

@FoamyGuy FoamyGuy merged commit 15e45fb into adafruit:main Jan 8, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 9, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e796bc0)
cea974f 
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.0.0 from 2.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#39 from fivesixzero/cleanup-and-doc
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.3.10 from 1.3.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#21 from tekktrik/doc/add-typing
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#22 from tekktrik/doc/rtd-formatting

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#12 from tekktrik/doc/add-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.3 from 0.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#33 from dannystaple/patch-2
@dannystaple dannystaple deleted the patch-2 branch January 9, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannystaple @FoamyGuy