Add some examples, improve the assembler #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Feb 25, 2021
Comment on lines
+92
to
+93
| if target[:1] in "0123456789": | ||
| assembled[-1] |= int(target) |
There was a problem hiding this comment.
This check will only work for single digit targets but it could be up to 32. Instead, you could try and int(target) and then catch the error.
There was a problem hiding this comment.
Not quite, but maybe the code is too clever as written. It looks whether the first character (if present) in target is a digit.
examples/pico-examples/hello.py
Outdated
| sm = rp2pio.StateMachine( | ||
| assembled, | ||
| frequency=80, | ||
| init=adafruit_pioasm.assemble("set pindirs 1"), |
There was a problem hiding this comment.
You shouldn't need this init or the set pin anymore.
examples/pico-examples/hello.py
Outdated
|
|
||
| sm = rp2pio.StateMachine( | ||
| assembled, | ||
| frequency=80, |
There was a problem hiding this comment.
The state machine can't go this slow and CP should now raise an error to tell you that.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 27, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.2.0 from 0.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#11 from adafruit/jepler-examples-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembler improvements:
Examples: