Fix type annotations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dhalbert merged 3 commits into adafruit:main from tekktrik:dev/fix-typing

May 23, 2023

Member

tekktrik commented May 23, 2023

Fixes #9 and adds a few extra corrections

tekktrik added 3 commits

May 23, 2023 10:58


          Fix typing imports

334a5d9


          Update existing annotations

5026e79


          Correction annotation for PCF8591.read()

1552eab

tekktrik requested a review from a team

May 23, 2023 15:06

dhalbert approved these changes

View reviewed changes

Contributor

dhalbert left a comment

👍 I was sad to see that ValueRange was only an example, and not included in the type annotation stuff.

dhalbert merged commit 47ddfe1 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@b417f43)

d483f40

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.16 from 1.0.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#11 from adafruit/dev/fix-pylint-jquery
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#10 from tekktrik/dev/fix-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet