Skip to content

timer-support #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 10, 2023
Merged

timer-support #30

merged 14 commits into from
Oct 10, 2023

Conversation

bablokb
Copy link
Contributor

@bablokb bablokb commented Jan 28, 2023

This PR adds timer-support for the PCF8523 (timer-A, timer-B, watchdog-timer).

@tekktrik tekktrik requested a review from a team January 28, 2023 16:42
@bablokb bablokb mentioned this pull request Feb 24, 2023
Merged
@bablokb
Copy link
Contributor Author

bablokb commented Feb 24, 2023

Note: currently discussing with @tannewt memory impacts of my (besides hardware-specifics) identical pull-request for the PCF8563.

@dhalbert
Copy link
Contributor

I have made this a draft because the corresponding PCF8563 PR,adafruit/Adafruit_CircuitPython_PCF8563#6, is still in progress, and the changes being made there. might analogously be made here.

@dhalbert dhalbert marked this pull request as draft April 14, 2023 13:56
@bablokb
Copy link
Contributor Author

bablokb commented Apr 14, 2023

I have made this a draft because the corresponding PCF8563 PR,adafruit/Adafruit_CircuitPython_PCF8563#6, is still in progress, and the changes being made there. might analogously be made here.

Yes, that was the plan. But nothing is happening there, I am waiting too.

@dhalbert
Copy link
Contributor

OK, adafruit/Adafruit_CircuitPython_PCF8563#6 is merged. Want to incorporate those changes too?

@bablokb
Copy link
Contributor Author

bablokb commented Sep 22, 2023

I somehow lost track (has been a while). I will check if this is in line with the PCF8563 code and report back or update the pull-request.

@bablokb
Copy link
Contributor Author

bablokb commented Oct 10, 2023

I updated the code and also added examples for clock and timer.

@bablokb bablokb marked this pull request as ready for review October 10, 2023 16:28
tannewt
tannewt approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will need a major version bump since it breaks the API to become a package.

@tannewt tannewt merged commit f0acff6 into adafruit:main Oct 10, 2023
@bablokb bablokb deleted the 4upstream branch October 11, 2023 09:55
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 17, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@87f545d)
3500118 
Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.4.11 from 1.4.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#27 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 2.0.0 from 1.5.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#30 from bablokb/4upstream

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bablokb @dhalbert @tannewt