Improve performance with (optional, disabled by default) manual sync #22
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add auto_write (default true) and sync method
Add manual sync method
gamblor21
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digging through the Arduino side of things, I found there's a manual sync step after any pixel change, whereas the CircuitPython libraries will by default auto-sync any time a pixel is changed. This is ideal from a user standpoint, but if you update more than one pixel at a time it slows down significantly, as there's an I2C transmit every time you update a single neopixel. For anyone who wants to update multiple pixels at a time, I've added a way to do a single manual sync after a lot of pixels are changed. Based on my tests, this really improves performance if making animations across e.g. a 2x2 multitrellis.
Of course, I've left the default behavior as-is for backwards compatibility.