Skip to content

Import PWMOut protocols on applicable platforms #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2022
Merged

Import PWMOut protocols on applicable platforms #63

merged 5 commits into from
Apr 21, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Apr 21, 2022

Resolves adafruit/Adafruit_CircuitPython_MotorKit/issues/45 by using new circuitpython_typing.pwmio.PWMOut Protocol for type annotations on platforms like the Jetson Nano which do not have pwmio.PWMOut implemented.

@tekktrik tekktrik requested a review from a team April 21, 2022 16:20
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dhalbert dhalbert merged commit 207953a into adafruit:main Apr 21, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 22, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 6.0.0 from 5.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#25 from tekktrik/dev/convert-to-properties

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.4.0 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#63 from tekktrik/dev/allow-pwmio-protocols
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using motorkit with Adafruit DC Motor Bonnet on Jetson Nano
2 participants