Skip to content

Pypi #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2018
Merged

Pypi #14

merged 4 commits into from
Jul 31, 2018

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Jul 31, 2018

@kattni kattni requested a review from brennen July 31, 2018 20:28
Copy link
Contributor

@brennen brennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing the autodoc_mock_imports removal; otherwise good I think.

@kattni
Copy link
Contributor Author

kattni commented Jul 31, 2018

Ah I did fix it and push it, but I didn't notice that it rejected the push because I'm not even with this branch. I'll get it fixed.

@brennen brennen merged commit 1df91fc into adafruit:master Jul 31, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 1, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.0.7 from 3.0.6:
  > travis: add "overwrite: true" to releases provider

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.2.0 from 3.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#13 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#14 from dhalbert/notimpl-freq-setter

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.0.0 from 0.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#8 from kattni/pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#14 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#13 from dhalbert/stepper-freq
cache:
pip: true

pip: true
deploy:
provider: releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a - here before provider. I think thats why the release files are missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no - here in the instructions or in any of the .travis.yml files I can find, including libs I didn't PR.

Please confirm this is necessary.

If so, we need to update the instructions and I will go back through all the libs we've done and add it.

Copy link
Contributor Author

@kattni kattni Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you mean a - before provider. I see. It apparently needs to be added each time, it's not automatic. I'll go back through everything and make sure it's there in the ones done before I started as well.

It's also not clear in the instructions that it needs to be added. It says "add the PyPi section including password". I didn't think to verify the rest, the instructions make it sound like the reformat did everything needed to the rest of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants