lines 216 and 220 both modify the broker string, thus not allowing reconnect to work

[bangell]

proto, dummy, self.broker = self.broker.split("/", 2)

self.broker gets modified during connect, however if you do a reconnect, it tries to parse broker again, however broker was already parsed down (removed the photo, and path). the split fails as broker only contains the host address and there are not enough values to unpack. I would have done a request for pull on this, but didn't know how you wanted to handle this situation.

my broker was set to: http://10.0.0.16

[bangell]

    try:
        proto, dummy, self.broker, path = self.broker.split("/", 3)
        # replace spaces in path
        path = path.replace(" ", "%20")
    except ValueError:
        proto, dummy, self.broker = self.broker.split("/", 2)
        path = ""

This code in connect will not work when called by reconnect because the broker string gets modified here. It fails in the except routine because broker is just the host address when called for second time so the split fails

[brentru]

@bangell Since self.broker is only within init and connect, we could handle this by creating a new broker variable and preserving the value of the original self.broker:

proto, dummy, broker, path = self.broker.split("/", 3)
proto, dummy, broker= self.broker.split("/", 2)

[jimbobbennett]

Hey @bangell - this should be fixed in the latest release. Can you test my fix please and see if it resolves this issue.

[bangell]

you bet!

…

On Apr 21, 2020, at 12:39 PM, Jim Bennett ***@***.***> wrote: Hey @bangell <https://github.com/bangell> - this should be fixed in the latest release <https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/releases/tag/2.2.0>. Can you test my fix please and see if it resolves this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJYYJ4U76LU43CPG4DDULLRNXZAJANCNFSM4ME6GBPQ>.

[bangell]

Thanks, it worked like a champ!