retry refreshing a few times, let us update faster too #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 23, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.5 from 2.9.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#101 from FoamyGuy/add_magtag_example Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#19 from ladyada/main > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#17 from makermelissa/main
tannewt
reviewed
Nov 23, 2020
| self.graphics.display.refresh() | ||
| while True: | ||
| try: | ||
| self.graphics.display.refresh() |
There was a problem hiding this comment.
Instead do time.sleep(self.graphics.display.time_to_refresh).
There was a problem hiding this comment.
does time_to_refresh count down or is it the 'max seconds' to refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid accidental exceptions when force-refreshing after, say, updating the background