Initial Version of Library #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Nov 13, 2020
ladyada
approved these changes
Nov 13, 2020
tannewt
reviewed
Nov 16, 2020
tannewt
reviewed
Nov 16, 2020
There was a problem hiding this comment.
Please please please start factoring out common code between the portal libraries instead of copying. Doing so will make them all more maintainable and easier to build upon. network, graphics and wifi_module are all things that could be used separately from MagTag. peripherals is what I'd expect the MagTag library to consist of. It encapsulates just the things that make the board unique.
| print("Response is", value) | ||
| except (ValueError, RuntimeError) as e: | ||
| print("Some error occured, retrying! -", e) | ||
| timestamp = time.monotonic() |
There was a problem hiding this comment.
else:
time.sleep(time.monotonic() - timestamp)There was a problem hiding this comment.
Fair enough. I'll create an issue for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the initial working version of the library.