Skip to content

Add MSA311 support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Add MSA311 support #18

merged 3 commits into from
Aug 26, 2022

Conversation

caternuson
Copy link
Contributor

For #17.

Refactors things a little and adds MSA311 support. The MSA301 and MSA311 share a common base class.

Tested both MSA301 and MSA311 simpletest example on QT PY M0

Adafruit CircuitPython 7.3.2 on 2022-07-20; Adafruit QT Py M0 with samd21e18
>>> import msa301_simpletest
-1.843413 0.517113 11.117935
-1.852989 0.564994 11.012596
-1.876929 0.517113 10.964714
-1.886506 0.526689 11.012596
-1.905658 0.536266 11.007808
Adafruit CircuitPython 7.3.2 on 2022-07-20; Adafruit QT Py M0 with samd21e18
>>> import msa311_simpletest
-0.478808 0.172371 10.074131
-0.440504 0.172371 10.035828
-0.536266 0.172371 10.093285
-0.555418 0.153219 10.131588
-0.555418 0.172371 10.016674

@caternuson caternuson requested a review from a team August 25, 2022 23:05
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one thing -- looks like a typo.

Co-authored-by: Dan Halbert <[email protected]>
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit c735ac1 into adafruit:main Aug 26, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 30, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_floppy to 1.0.5 from 1.0.4:
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation
  > Fix version strings in workflow files
  > Update version string

Updating https://github.com/adafruit/Adafruit_CircuitPython_MSA301 to 1.3.0 from 1.2.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#18 from caternuson/msa311_support
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#14 from sokratisvas/remove-mask

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter to 2.0.14 from 2.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BerryMed_Pulse_Oximeter#12 from Neradoc/fix-typing-import
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.12 from 2.0.11:
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation
  > Fix version strings in workflow files
  > Update version string

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.3.1 from 5.3.0:
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation
@tekktrik tekktrik mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants