chore: omit print when typing can't pull in #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates the order for typing imports so the busio I2C import (only used for typing) isn't pulled in at all if we can't use typing
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 4, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.3.0 from 1.2.12: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#14 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.6.0 from 1.5.12: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#18 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.7.0 from 1.6.3: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#36 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.4.0 from 1.3.11: > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#19 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.4.0 from 1.3.20: > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#30 from prcutler/root-group-fourwire-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.2.0 from 1.1.17: > Merge pull request adafruit/Adafruit_CircuitPython_IL0398#15 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.3.0 from 1.2.12: > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#18 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.4.0 from 1.3.11: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#33 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.5.0 from 1.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#28 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.3.0 from 1.2.17: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#38 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 1.0.0 from 0.3.16: > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#17 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.1.0 from 1.0.20: > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#14 from imnotjames/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_OV2640 to 1.2.0 from 1.1.11: > Merge pull request adafruit/Adafruit_CircuitPython_OV2640#26 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_OV to 1.1.0 from 1.0.14: > Merge pull request adafruit/Adafruit_CircuitPython_OV#19 from prcutler/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 6.3.0 from 6.2.11: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#130 from dhalbert/no-show Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.4.0 from 1.3.9: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#20 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.5.0 from 1.4.11: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#18 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.4.0 from 1.3.12: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#21 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.4.0 from 1.3.10: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#20 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.3.0 from 1.2.20: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#17 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.2.0 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#22 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.2.0 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#13 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.6.0 from 1.5.13: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#32 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.3.0 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#27 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_TT21100 to 1.0.0 from 0.8.7: > Merge pull request adafruit/Adafruit_CircuitPython_TT21100#4 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_UC8151D to 1.3.0 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_UC8151D#11 from prcutler/main Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#52 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.8.0 from 2.7.7: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#38 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#16 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.8.0 from 1.7.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#40 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Notification to 1.0.0 from 0.9.16: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Notification#16 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_FlipC to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_FlipC#10 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32S2TFT to 1.2.0 from 1.1.10: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32S2TFT#10 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.2.0 from 2.1.22: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#41 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.20.0 from 1.19.1: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#75 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.3.0 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#49 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.15.4 from 1.15.3: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#97 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.8.0 from 3.7.14: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#68 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.8.0 from 1.7.12: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#44 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_VCNL4020 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's currently a print statement that's used when an import error occurs during an import for typing. other libraries - such as
adafruit_rsaandadafruit_pcd8544will silently ignore the import issues because it's expected on a circuitpython board for typing to not exist.also updates the order for typing imports so the busio I2C import (only used for typing) isn't pulled in at all if we can't use typing
previous behavior: any time this library is used on circuitpython a confusing
Couldn't importis emitted into the log or onto the associated screennew behavior: crickets (and maybe a few bytes less memory because we don't pull in I2C from busio if we don't need to)