Skip to content

Revert "Fixed I2C Status Bit" #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Revert "Fixed I2C Status Bit" #7

merged 1 commit into from
Oct 2, 2019

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Oct 2, 2019

Reverts #6

@ladyada ladyada requested a review from caternuson October 2, 2019 04:05
@caternuson
Copy link
Contributor

Yep. Like that.

The integrity check looks like it is only a one-time power up thing:
image
so not something that is expected to happen sometime later in operation.

Also, the PR #6 code:

if self._buffer[2] & 0x01:

is checking the first bit of the third byte returned, which is the second byte of sensor data.
image

Tested for good measure:
1002190844

pi@raspberrypi:~ $ python3 mprls_simpletest.py 
(1008.0291499903257,)
(1008.0471294721156,)
(1007.9221720736759,)
(1008.0111705085358,)
(1007.9935763013558,)

runs forever.

@caternuson caternuson merged commit 29fd429 into master Oct 2, 2019
@ladyada
Copy link
Member Author

ladyada commented Oct 2, 2019

thank u!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 2, 2019
@evaherrada evaherrada deleted the revert-6-patch-1 branch June 21, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants