Expose velocity attribute #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Mar 8, 2022
| @@ -38,17 +38,17 @@ class NoteOff(MIDIMessage): # pylint: disable=duplicate-code | |||
| def __init__(self, note, velocity=0, *, channel=None): | |||
| self.note = note_parser(note) | |||
| """key, either int (0-127) or string that will be turned off """ | |||
| self._velocity = velocity | |||
| self.velocity = velocity | |||
There was a problem hiding this comment.
Please add a comment after it like self.note above. That will make it show up in the docs.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 10, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD4X to 1.3.0 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_SCD4X#13 from tekktrik/dev/clearer-i2c-failure > Fixed readthedocs build > Post-patch cleanup > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.7 from 1.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#48 from tekktrik/dev/expose-velocity-attr > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47 by exposing the
velocityattribute, just asNoteOndoes. Required disablingduplicate-codepylint warning.