Skip to content

digital_inout.py: add exceptions when ipol register is absent #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2024
Merged

digital_inout.py: add exceptions when ipol register is absent #60

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87800a3
digital_inout.py: add exceptions when ipol register is absent
regicidalplutophage Oct 6, 2024
85974d9
Appease pylint
regicidalplutophage Oct 6, 2024
824f7ba
Update digital_inout.py
regicidalplutophage Oct 6, 2024
2dbe675
Add requested changes
regicidalplutophage Oct 7, 2024
84a1f25
Merge branch 'adafruit:main' into patch-1
regicidalplutophage Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions adafruit_mcp230xx/digital_inout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,22 @@ def invert_polarity(self) -> bool:
"""The polarity of the pin, either True for an Inverted or
False for an normal.
"""
if _get_bit(self._mcp.ipol, self._pin):
return True
return False
try:
if _get_bit(self._mcp.ipol, self._pin):
return True
return False
except AttributeError:
return False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proactively testing for the attribute is clearer than catching the error.

Suggested change
try:
if _get_bit(self._mcp.ipol, self._pin):
return True
return False
except AttributeError:
return False
if hasattr(self._mcp, "ipol") and _get_bit(self._mcp.ipol, self._pin):
return True
return False


@invert_polarity.setter
def invert_polarity(self, val: bool) -> None:
if val:
self._mcp.ipol = _enable_bit(self._mcp.ipol, self._pin)
try:
self._mcp.ipol = _enable_bit(self._mcp.ipol, self._pin)
except AttributeError as error:
raise ValueError("Inverted polarity is not supported.") from error
else:
self._mcp.ipol = _clear_bit(self._mcp.ipol, self._pin)
try:
self._mcp.ipol = _clear_bit(self._mcp.ipol, self._pin)
except AttributeError:
return