remove bad-whitespace pylint directive #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

makermelissa merged 3 commits into adafruit:master from jepler:remove-bad-whitespace-directive

Aug 28, 2020

Contributor

jepler commented Aug 23, 2020

This directive has been removed from pylint 2.6.0.

dhalbert requested a review from a team

August 23, 2020 17:16


          remove bad-whitespace pylint directive

963b81e

jepler force-pushed the remove-bad-whitespace-directive branch from 2727f05 to 963b81e Compare

August 23, 2020 18:11

Contributor Author

jepler commented Aug 23, 2020

Fails due to unrelated pylint diagnostics, such as

adafruit_mcp230xx/digital_inout.py:117:12: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)

Contributor

kattni commented Aug 24, 2020

@jepler These should be updated to use raise exception from exc formatting.

jepler added 2 commits

August 24, 2020 15:56


          address pylint raise-missing-from diagnostics

db4fc2d


          address new invalid-name diagnostic

65105a5

makermelissa approved these changes

View reviewed changes

Collaborator

makermelissa left a comment

Looks good.

makermelissa merged commit 3f04abb into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@b17b8fd)

d96a444

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.1 from 2.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#33 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#2 from adafruit/dependency

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.3.1 from 3.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#84 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.2.2 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#29 from adafruit/tannewt-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#28 from ronfischler/set-changed-during-iteration-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.0 from 2.8.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#90 from kmatch98/bitmap_mutable

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.7 from 0.11.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#38 from tannewt/run_tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#47 from tannewt/run_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet