Improve interrupt #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
requested changes
May 30, 2019
adafruit_mcp230xx/mcp23017.py
Outdated
| @@ -234,3 +237,43 @@ def io_control(self): | |||
| @io_control.setter | |||
| def io_control(self, val): | |||
| self._write_u8(_MCP23017_IOCON, val) | |||
|
|
|||
| @property | |||
| def int_flg(self): | |||
There was a problem hiding this comment.
Could we spell out the name so it’s easier to read like int_flag?
adafruit_mcp230xx/mcp23017.py
Outdated
| port B ----> pins 8-15 | ||
| """ | ||
| intf = self._read_u16le(_MCP23017_INTFA) | ||
| flg = [i for i in range(16) if intf & (1 << i)] |
There was a problem hiding this comment.
Variable names would be helpful too
adafruit_mcp230xx/mcp23017.py
Outdated
| return flg | ||
|
|
||
| @property | ||
| def int_flga(self): |
adafruit_mcp230xx/mcp23017.py
Outdated
| return flga | ||
|
|
||
| @property | ||
| def int_flgb(self): |
There was a problem hiding this comment.
@makermelissa, Sorry it took me this long to respond, I couldn't get to this until today. I made the suggested changes and I also added an example that uses the new functions and the RPi.GPIO.add_event_detect function for an efficient use of the hardware interrupt functionality of the MCP23017 IC.
Added Interrupt example using Rpi.GPIO.add_event_detect() and a callback.
makermelissa
approved these changes
Jun 5, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 5, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.1.0 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#14 from jardiamj/improve_interrupt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that you need to clear the interrupts at the beginning otherwise the interrupts never happen, also reading the pin value doesn't seem to clear them so I added the functions to clear the interrupts by reading from INTCAPA/B.
I also wrote properties to get the pins flagged as causing an interrupt (INTFA/B), they return a list of pin numbers for which their bit in INTFA/B is set.
I didn't test the example in mcp230xx_leds_and_buttons_irq.py but I suspect it doesn't work without clearing the interrupts before the while Tue loop.