-
Notifications
You must be signed in to change notification settings - Fork 6
Lint #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Lint #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use glob to test everything in the adafruit_max7219 directory
I fixed up the travis file but it looks like |
Ok, i removed a extra empty line in __init__.py |
circuitpython-travis-build-tools > circuitpython-build-tools
kattni
approved these changes
Dec 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 10, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.0.0 from 2.0.1: > manual merge Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.0.1 from 2.0: > fix travis typo > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#4 from chickadee-tech/lint Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.0.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#3 from mrmcwethy/lint Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.0.0 from 2.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#1 from mrmcwethy/lint > Add simple datalogging example. Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 2.0.0 from v1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#15 from tannewt/lint Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.0.0 from 0.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#7 from mrmcwethy/lint > Tidy up Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.0.1 from 2.0: > fix typo in yml > Merge branch 'tannewt-lint'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the pylint process to AdaFruit_CircuitPython_MAX7219 library. I have tested the result using two of my test program on a Metro M0 CP 2.1