-
Notifications
You must be signed in to change notification settings - Fork 6
Make BCDDigits chainable #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bschymanski is this new functionality something you have the hardware to test? |
|
I actually ordered something to help with this, but mail is turtle-pace right now, converting to draft in the meantime. I'll re-convert when I get it and finalize this PR. |
Hardware arrived, now I just need to figure out which moving box has my soldering equipment >:( |
Pros: I have the prototype working! |
@tekktrik Glad to see someone is taking this up, I think you might be in a similar place where I left off. I tried to get chained BCD Digits working after I implemented I have the hardware to test when you're ready or if you need some help! |
Unfortunately, I think I'm going to close this for now since I haven't had time to work on and don't know when I will. I'll keep the branch though, and hopefully I'll be able to come back to this. |
Not tested.
Resolves #39 by changing inheritance of
BCDDigits
toChainableMAX7219
. Also adds a value check to notify if a digit is ever out of range.