Skip to content

Make BCDDigits chainable #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Make BCDDigits chainable #40

wants to merge 6 commits into from

Conversation

tekktrik
Copy link
Member

Not tested.

Resolves #39 by changing inheritance of BCDDigits to ChainableMAX7219. Also adds a value check to notify if a digit is ever out of range.

@tekktrik tekktrik requested a review from a team March 30, 2022 15:01
@tekktrik tekktrik changed the title Max BCDDigits chainable Make BCDDigits chainable Apr 3, 2022
@FoamyGuy
Copy link
Contributor

FoamyGuy commented Apr 4, 2022

@bschymanski is this new functionality something you have the hardware to test?

@bschymanski
Copy link

i will download the new code and will test this with two daisychained MAX7219 hopefully tomorrow

@tekktrik tekktrik marked this pull request as draft April 25, 2022 20:50
@tekktrik
Copy link
Member Author

I actually ordered something to help with this, but mail is turtle-pace right now, converting to draft in the meantime. I'll re-convert when I get it and finalize this PR.

@tekktrik
Copy link
Member Author

tekktrik commented May 5, 2022

Hardware arrived, now I just need to figure out which moving box has my soldering equipment >:(

@tekktrik
Copy link
Member Author

Pros: I have the prototype working!
Cons: It's not working as intended, chances are this will take me a while!

@FlantasticDan
Copy link
Contributor

@tekktrik Glad to see someone is taking this up, I think you might be in a similar place where I left off. I tried to get chained BCD Digits working after I implemented ChainableMAX7219 in #37 but found that it would require some reworking of the existing BCD implementation I wasn't prepared to undertake.

I have the hardware to test when you're ready or if you need some help!

@tekktrik
Copy link
Member Author

Unfortunately, I think I'm going to close this for now since I haven't had time to work on and don't know when I will. I'll keep the branch though, and hopefully I'll be able to come back to this.

@tekktrik tekktrik closed this Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascade several 7-segment display modules
4 participants