Skip to content

Add rotation function to max7219.py #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add rotation function to max7219.py #29

wants to merge 7 commits into from

Conversation

bluejazzCHN
Copy link

using this function can change the direction of display of LED matrices

@ladyada
Copy link
Member

ladyada commented Jan 7, 2021

@deshipu wanna test it out?

@jposada202020
Copy link

@bluejazzCHN Would you mind if we could make at least pass the CI this PR also? :)
Thanks

@bluejazzCHN
Copy link
Author

@bluejazzCHN Would you mind if we could make at least pass the CI this PR also? :)
Thanks

it's OK. do as you think.

@jposada202020
Copy link

I made the changes in your repo via PR as you do not have a tracked branch. Thanks

@bluejazzCHN
Copy link
Author

@jposada202020 i accepted pull from you, please check the result.

@jposada202020
Copy link

@bluejazzCHN yes thanks, we have two options:

  1. that you push the changes here
  2. Make a new PR. (If this it the preferred way could you make a branch, this allows contributor and maintainer to work in the same branch and would facilitate the process in cases like this, as mentioned here https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch

At this stage both options are ok, whatever is easier for you :) thanks

@evaherrada evaherrada changed the base branch from master to main June 7, 2021 15:50
@FoamyGuy
Copy link
Contributor

Thanks for working on this @bluejazzCHN. It wasn't passing the CI checks still. But we have had a very similar feature introduced by #37 with an adaptable custom chained matrix feature. Closing this for now. Please feel free to make a new PR if you want to modify the current version.

@FoamyGuy FoamyGuy closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants